This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PowerPC floating point little-endian [2 of 15]
- From: Andreas Jaeger <aj at suse dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 09 Aug 2013 08:20:44 +0200
- Subject: Re: PowerPC floating point little-endian [2 of 15]
- References: <20130710012435 dot GN2602 at bubble dot grove dot modra dot org> <20130710012520 dot GO2602 at bubble dot grove dot modra dot org> <20130809043946 dot GS3294 at bubble dot grove dot modra dot org>
On 08/09/2013 06:39 AM, Alan Modra wrote:
> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_acoshl.c b/sysdeps/ieee754/ldbl-128ibm/e_acoshl.c
> index abc78a3..8a4a5bb 100644
> --- a/sysdeps/ieee754/ldbl-128ibm/e_acoshl.c
> +++ b/sysdeps/ieee754/ldbl-128ibm/e_acoshl.c
> @@ -36,8 +36,12 @@ __ieee754_acoshl(long double x)
> {
> long double t;
> int64_t hx;
> - u_int64_t lx;
> - GET_LDOUBLE_WORDS64(hx,lx,x);
> + uint64_t lx;
> + double xhi, xlo;
> +
> + ldbl_unpack (x, &xhi, &xlo);
> + EXTRACT_WORDS64 (hx, xhi);
> + EXTRACT_WORDS64 (lx, xlo);
> if(hx<0x3ff0000000000000LL) { /* x < 1 */
> return (x-x)/(x-x);
> } else if(hx >=0x41b0000000000000LL) { /* x > 2**28 */
Alan, you're replacing GET_LDOUBLE_WORDS64 with ldlb_unpack,
EXTRACT_WORDS64;EXTRACT_WORDS64 - why can't you just change the macro
GET_LDOUBLE_WORDS64 to do the right thing?
The change itself looks fine, I just wonder why you did it this way,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126