This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PowerPC floating point little-endian [8 of 15]
- From: Andreas Jaeger <aj at suse dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 10 Jul 2013 07:59:38 +0200
- Subject: Re: PowerPC floating point little-endian [8 of 15]
- References: <20130710012435 dot GN2602 at bubble dot grove dot modra dot org> <20130710012912 dot GU2602 at bubble dot grove dot modra dot org>
On 07/10/2013 03:29 AM, Alan Modra wrote:
> Corrects floating-point environment code for little-endian.
>
> 2013-07-10 Anton Blanchard <anton@au1.ibm.com>
>
> * sysdeps/powerpc/fpu/fenv_libc.h (fenv_union_t): Replace int
> array with long long.
> * sysdeps/powerpc/fpu/e_sqrt.c (__slow_ieee754_sqrt): Adjust.
> * sysdeps/powerpc/fpu/e_sqrtf.c (__slow_ieee754_sqrtf): Adjust.
> * sysdeps/powerpc/fpu/fclrexcpt.c (__feclearexcept): Adjust.
> * sysdeps/powerpc/fpu/fedisblxcpt.c (fedisableexcept): Adjust.
> * sysdeps/powerpc/fpu/feenablxcpt.c (feenableexcept): Adjust.
> * sysdeps/powerpc/fpu/fegetexcept.c (__fegetexcept): Adjust.
> * sysdeps/powerpc/fpu/feholdexcpt.c (feholdexcept): Adjust.
> * sysdeps/powerpc/fpu/fesetenv.c (__fesetenv): Adjust.
> * sysdeps/powerpc/fpu/feupdateenv.c (__feupdateenv): Adjust.
> * sysdeps/powerpc/fpu/fgetexcptflg.c (__fegetexceptflag): Adjust.
> * sysdeps/powerpc/fpu/fraiseexcpt.c (__feraiseexcept): Adjust.
> * sysdeps/powerpc/fpu/fsetexcptflg.c (__fesetexceptflag): Adjust.
> * sysdeps/powerpc/fpu/ftestexcept.c (fetestexcept): Adjust.
The code is fine, I just wonder whether that will not have a performance
impact on 32-bit PowerPC. Please run the complete bench tests with and
without your complete patch set on both 32-bit and 64-bit PowerPC and
report any changes,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126