This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH rsa/stdint_noheaders] Cleanup: Add #include <stdint.h> for uint[32|64]_t usage (except installed headers)
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, Ryan Arnold <rsa at us dot ibm dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 30 May 2013 12:23:29 -0500
- Subject: Re: [PATCH rsa/stdint_noheaders] Cleanup: Add #include <stdint.h> for uint[32|64]_t usage (except installed headers)
- References: <1367425419 dot 9067 dot 281 dot camel at localhost dot localdomain> <20130516133649 dot GA11396 at domone dot kolej dot mff dot cuni dot cz> <CAAKybw8EP358UABnY2crSGVJxC7R_U-19t95XY0Fw+Cdd9GWwA at mail dot gmail dot com> <CAAKybw-iGGtV9E8tfBmX1Wv_fEq-rrir2pHx8=2gPbNDrKrtOQ at mail dot gmail dot com> <87ppwdo7ho dot fsf at kepler dot schwinge dot homeip dot net>
On Sun, May 26, 2013 at 2:40 PM, Thomas Schwinge
<thomas@codesourcery.com> wrote:
>> >> On Wed, May 01, 2013 at 11:23:39AM -0500, Ryan Arnold wrote:
>> >>> Per Roland's suggestion in "[PATCH rsa/stdint] Cleanup: Add #include
>> >>> <stdint.h> for uint[32|64]_t usage" I have removed the installed headers
>> >>> from this patch, and separated the ChangeLog entries into the proper
>> >>> subdirectory ChangeLogs.
>
>> Pushed upstream:
>>
>> commit e054f494306530720114b321b3d97ca2f397cbbb
>> Author: Ryan S. Arnold <rsa@linux.vnet.ibm.com>
>> Date: Wed May 1 10:46:34 2013 -0500
>>
>> Add #include <stdint.h> for uint[32|64]_t usage (except installed headers).
>
> I'm seeing:
>
> make[2]: Entering directory `[...]/locale'
> /usr/bin/perl gen-translit.pl < C-translit.h.in > C-translit.h.tmp
> mv -f C-translit.h.tmp C-translit.h
>
> ..., resulting in:
>
> diff --git locale/C-translit.h locale/C-translit.h
> index 98f66e2..d7ec778 100644
> --- locale/C-translit.h
> +++ locale/C-translit.h
> @@ -1,5 +1,3 @@
> -#include <stdint.h>
> -
> #define NTRANSLIT 1355
> static const uint32_t translit_from_idx[] =
> {
>
> Should a) the change be reverted for this file (that is, the above hunk
> be applied), or b) the generator be changed to emit that #include, or,
> heck, c) the autogenerated file be removed from the source repository
> (and then some)?
Siddhesh pointed out to me that I should have modified the perl script
which is used to generate this file, rather than the generated file.
I'll do that shortly.
Ryan