Re: [PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA

[Mike Frysinger <vapier at gentoo dot org>]

On Tuesday 28 May 2013 19:15:39 Roland McGrath wrote:
> > On Tuesday 28 May 2013 15:32:51 Carlos O'Donell wrote:
> > > On 05/25/2013 02:41 PM, Mike Frysinger wrote:
> > > > +#define PTR_ALIGN_UP(base, size) \
> > > > +  (void *) ALIGN_UP ((uintptr_t) (base), (size))
> > > 
> > > Almost done.
> > > 
> > > We install cdefs.h and thus these macros need __ to avoid being
> > > in the user's namespace.
> > 
> > not exactly.  i picked include/sys/cdefs.h instead of misc/sys/cdefs.h
> > because the latter is for installing while the former is for internal
> > use.
> 
> I don't think you should use include/sys/cdefs.h for that sort of purpose.
> If it's internal-only stuff that doesn't directly relate to something else
> that's in the API of an installed header, then do it purely in a private
> header.

i don't see why not.  sys/cdefs.h is for general C defines and these macros 
seem to sit in there.

libc-internal.h is really the only other place that'd be appropriate in a 
general dumping ground sort of way.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.