This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix comment typos in libio/stdio.h
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Murilo Opsfelder Araújo <mopsfelder at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 22 May 2013 20:51:33 -0400
- Subject: Re: [PATCH] Fix comment typos in libio/stdio.h
- References: <1369262403-14172-1-git-send-email-mopsfelder at gmail dot com> <519D58E2 dot 3020307 at redhat dot com> <CA+LKeY71eC003fBayMpjd=b3iSQowzAbH1r+OvVFc318-brPJA at mail dot gmail dot com>
On 05/22/2013 08:03 PM, Murilo Opsfelder Araújo wrote:
> On Wed, May 22, 2013 at 8:46 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> [..]
>> May I suggest you look over our todo list for something you
>> might find interesting?
>>
>> http://sourceware.org/glibc/wiki/Development_Todo/Master
>
> I'll check it out and see what I can contribute.
Thank you.
>>> This is my very first contribution to glibc and any feedback is welcome.
>>
>> Unfortunately your patch is wrong.
>>
>> While the constants say "*_MAX" they are actually minimums.
>>
>> You are guaranteed at least TMP_MAX unique filenames.
>>
>> You are guaranteed at least FOPEN_MAX files open simultaneously.
>>
>> Their names are lamentably confusing but part of the standard.
>
> Sounds I got deluded by the "*_MAX" in the names. Thanks, Carlos.
>
> I've also received some private messages with explanations and I'd
> like to thank you all for reviewing and advising.
You are welcome. We're always happy to have more help in the
glibc community. If you have any questions please don't
hesitate to ask on libc-help@sourceware.org.
Cheers,
Carlos.