This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX
- From: Andreas Jaeger <aj at suse dot com>
- To: Andi Kleen <ak at linux dot intel dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 14 May 2013 09:14:04 +0200
- Subject: Re: [PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX
- References: <1368225725-14283-1-git-send-email-andi at firstfloor dot org> <1368225725-14283-3-git-send-email-andi at firstfloor dot org> <518F5B45 dot 6080301 at suse dot com> <20130513223037 dot GG4072 at tassilo dot jf dot intel dot com>
On 05/14/2013 12:30 AM, Andi Kleen wrote:
+ {
+ char *end;
+ int val;
+
+ if (s[nlen] != '=')
+ {
+ complain (PAIR ("pthreads: invalid GLIBC_MUTEX syntax: missing =\n"));
These warnings are not localized - can/want we have them localized?
I doubt the locale facility is up at this point.
pthreads initialization is very early and I had a lot of problems
with such dependencies.
That's what I feared - if that's the case, ignore my comments ;)
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126