This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ 15362] Fix fwrite() reading beyond end of buffer in error path
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Eric Biggers <ebiggers3 at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 17 Apr 2013 18:16:25 +0530
- Subject: Re: [PATCH][BZ 15362] Fix fwrite() reading beyond end of buffer in error path
- References: <20130417043114 dot GA4239 at zzz dot kirk dot macalester dot edu>
On Tue, Apr 16, 2013 at 11:31:14PM -0500, Eric Biggers wrote:
> I have not been able to run the full test suite because an unrelated test
> (math/test-ldouble) fails even without my patch. Also, I did not add a test
Run make check with -k and record which tests fail due to this patch
(if any).
> - /* Try to maintain alignment: write a whole number of blocks.
> - dont_write is what gets left over. */
> + /* Try to maintain alignment: write a whole number of blocks. */
There should be two spaces after the end of the sentence.
The fix looks OK otherwise. Please confirm that the rest of the
testsuite is fine after this change. Please wait for one more
reviewer to go through this. Once the final version of the patch is
ready after review, I can commit it for you.
Thanks,
Siddhesh