This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[COMMITTED] Fix off-by-one bug in tst-fwrite-error


Hi,

tst-fwrite-error did not allocate enough space for the string 'world'
and its NULL terminator.  I fixed this as obvious.

Siddhesh

commit 5cb26d0aed9c7414f0d391a0ca766786625de8b5
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Mon Apr 15 11:35:43 2013 +0530

    Fix off-by-one bug in tst-fwrite-error
    
    tst-fwrite-error did not allocate enough space for the string 'world'
    and its NULL terminator.  Fixed.

diff --git a/ChangeLog b/ChangeLog
index b80865e..ac1d263 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 2013-04-15  Siddhesh Poyarekar  <siddhesh@redhat.com>
 
+	* libio/tst-fwrite-error.c (do_test): Fix BUF array definition.
+
 	* benchtests/Rules (bench-deps): Collect dependencies into a
 	single variable.  Add Makefile to dependencies.
 	($(objpfx)bench-%.c): Depend on bench-deps.
diff --git a/libio/tst-fwrite-error.c b/libio/tst-fwrite-error.c
index e2507ef..87c8766 100644
--- a/libio/tst-fwrite-error.c
+++ b/libio/tst-fwrite-error.c
@@ -36,7 +36,7 @@ do_test (void)
       return 1;
     }
 
-  char buf[5] = "world";
+  char buf[] = "world";
   setvbuf (fp, NULL, _IONBF, 0);
   close (fd);
   unlink (tmpl);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]