This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Extend i486 pthread_cond_timedwait to use futex syscall with absolute timeout
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, libc-alpha at sourceware dot org
- Date: Thu, 11 Apr 2013 08:01:22 +0530
- Subject: Re: [PATCH] Extend i486 pthread_cond_timedwait to use futex syscall with absolute timeout
- References: <mvm38uy1xws dot fsf at hawking dot suse dot de> <5165BD39 dot 8010108 at redhat dot com>
On Wed, Apr 10, 2013 at 03:27:53PM -0400, Carlos O'Donell wrote:
> > * sysdeps/unix/sysv/linux/i386/i486/pthread_cond_timedwait.S
> > (__pthread_cond_timedwait): If possible use FUTEX_WAIT_BITSET to
> > directly use absolute timeout.
>
> Looks good to me. I can't say I did an amazingly thorough review, but
> I did follow the changes. Thanks.
>
FWIW, I had done a review[1] (and tested it locally) when Andreas had
posted it last year and also asked for a second review. It did not go
in because of the 2.17 freeze.
Siddhesh
[1] http://sourceware.org/ml/libc-alpha/2012-12/msg00080.html