This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Re: [PATCH 3/6] Reinstantiate fd range check if and only if defined _STRICT_FD_SIZE_CHECK=1
- From: chrubis at suse dot cz
- To: Arjan van de Ven <arjan at linux dot intel dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, KOSAKI Motohiro <kosaki dot motohiro at gmail dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 3 Apr 2013 17:53:38 +0200
- Subject: Re: Re: [PATCH 3/6] Reinstantiate fd range check if and only if defined _STRICT_FD_SIZE_CHECK=1
- References: <20130403094821 dot GA1545 at rei> <515C4C24 dot 2070703 at linux dot intel dot com>
Hi!
> >> How so? _FORTIFY_SOURCE is not enabled by default. If you switch it
> >> on, there are other (valid) uses which break.
> >
> > That is simply not true. It's not turned on in glibc by default but
> > several build systems enable it system-wide. For example SUSE
> > buildservice.
> >
>
> ... and that is done deliberately accepting that it is breaking some broken code.
> if you don't want to deal with it, then don't enable it!
> (and if it's for one package only, it's up to the people who added it
> to cflags, to unadd it inside their specfile)
That is true for the broken code, but from the initial discussion that
leads to this patch, allocating the fd_set array is estabilished
practice although adopted from BSD. I would say that line between bug
and feature is not clear in this case.
--
Cyril Hrubis
chrubis@suse.cz