This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Re: [PATCH 3/6] Reinstantiate fd range check if and only if defined _STRICT_FD_SIZE_CHECK=1


Hi!
> >> How so?  _FORTIFY_SOURCE is not enabled by default.  If you switch it
> >> on, there are other (valid) uses which break.
> >
> > That is simply not true. It's not turned on in glibc by default but
> > several build systems enable it system-wide. For example SUSE
> > buildservice.
> >
> 
> ... and that is done deliberately accepting that it is breaking some broken code.
> if you don't want to deal with it, then don't enable it!
> (and if it's for one package only, it's up to the people who added it
> to cflags, to unadd it inside their specfile)

That is true for the broken code, but from the initial discussion that
leads to this patch, allocating the fd_set array is estabilished
practice although adopted from BSD. I would say that line between bug
and feature is not clear in this case.

-- 
Cyril Hrubis
chrubis@suse.cz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]