This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use mantissa_t in __mpexp


On Tuesday, April 02, 2013 17:43:41 Siddhesh Poyarekar wrote:
> On Tue, Apr 02, 2013 at 02:05:19PM +0200, Andreas Jaeger wrote:
> > On Tuesday, April 02, 2013 17:28:02 Siddhesh Poyarekar wrote:
> > > Hi,
> > > 
> > > Here's a minor cleanup in mpexp to use mantissa_t instead of
> > > double.
> > > I have also adjusted HALFRAD accordingly so that it is integral on
> > > x86_64.  Verified that this works fine on x86_64 and does not
> > > regress
> > > the testsuite.  OK to commit?
> > 
> > I see usage of HALFRAD also in sincos32.c and mpsqrt.c. Will you
> > change have any effect on these?
> 
> In both cases they're used for mantissa digits, so they will not have
> any negative effect.  In mpsqrt.c, the constant will be written in by
> the link editor according to the type of mantissa_t.  In sincos32.c,
> there should be a minor performance advantage since the compiler will
> not do the unnecessary conversion to double for the comparison.

In that case your patch is fine,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]