This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH v2 0/6] fix wrong program abort on __FD_ELT
- From: kosaki dot motohiro at gmail dot com
- To: libc-alpha at sourceware dot org
- Cc: KOSAKI Motohiro <kosaki dot motohiro at gmail dot com>
- Date: Fri, 29 Mar 2013 11:17:18 -0400
- Subject: [PATCH v2 0/6] fix wrong program abort on __FD_ELT
From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Currently, FD_SET, FD_CLR and FD_ISSET make program abort when
passing >__FD_SETSIZE value and _FORTIFY_SOURCE is greater than 0.
However it is wrong. Linux accept BSD style dynamic fd table allocations
likes below over 10 years.
http://netbsd.gw.com/cgi-bin/man-cgi?select++NetBSD-4.0
fd_set *fdsr;
int max = fd;
fdsr = (fd_set *)calloc(howmany(max+1, NFDBITS),
sizeof(fd_mask));
if (fdsr == NULL) {
...
return (-1);
}
FD_SET(fd, fdsr);
n = select(max+1, fdsr, NULL, NULL, &tv);
...
free(fdsr);
Moreover this technique is already in use multiple applications. And unfortunately, Ubuntu turn on _FORTIFY_SOURCE=2 by default and then user can hit this issue easily if bump up RLIMIT_NOFILE.
This patch series restrict fd argument check to only work when _STRICT_FD_SIZE_CHECK is set.
patch [1/6] is not a part of this series. it's just trivial fix. however patch [4/6] depend on it and then I decide to include.
patch [2/6], [3/6] and [4/6] are logically pieces of one big change. They are split only for easy reviewing. [2/6] just removes old wrong argument check and [3/6] resurrect it and [4/6] updates abilist.
patch [5/6] adds some tests for dynamic fd_set allocations.
patch [6/6] suppress out of bound warning when using above howmany() technique. This is related but independent patch.
KOSAKI Motohiro (6):
[1/6] mips: fix abi sort order
[2/6] __fdelt_chk: Removed range check
[3/6] Reinstantiate fd range check if and only if defined _STRICT_FD_SIZE_CHECK=1
[4/6] Add __fdelt_check and __fdelt_check_warn to libc.abilist
[5/6] tst-chk1: add fd_set dynamic allocation test
[6/6] __FDS_BITS: Added cast to __fd_mask* to avoid warning.
ChangeLog | 43 ++++++++++++++++++++
Versions.def | 1 +
debug/Makefile | 6 ++-
debug/Versions | 3 +
debug/fdelt_chk.c | 12 +++++-
debug/tst-chk1.c | 31 +++++++++++++-
debug/tst-chk7.c | 3 +
debug/tst-lfschk7.c | 2 +
misc/bits/select2.h | 8 ++--
misc/sys/select.h | 6 +-
ports/ChangeLog.aarch64 | 5 ++
ports/ChangeLog.alpha | 5 ++
ports/ChangeLog.arm | 5 ++
ports/ChangeLog.ia64 | 5 ++
ports/ChangeLog.m68k | 7 +++
ports/ChangeLog.mips | 14 ++++++
ports/ChangeLog.powerpc | 5 ++
ports/ChangeLog.tile | 9 ++++
.../unix/sysv/linux/aarch64/nptl/libc.abilist | 4 ++
.../unix/sysv/linux/alpha/nptl/libc.abilist | 4 ++
.../sysdeps/unix/sysv/linux/arm/nptl/libc.abilist | 4 ++
.../sysdeps/unix/sysv/linux/ia64/nptl/libc.abilist | 4 ++
.../sysv/linux/m68k/coldfire/nptl/libc.abilist | 4 ++
.../unix/sysv/linux/m68k/m680x0/nptl/libc.abilist | 4 ++
.../unix/sysv/linux/mips/mips32/nptl/libc.abilist | 20 +++++----
.../sysv/linux/mips/mips64/n32/nptl/libc.abilist | 4 ++
.../sysv/linux/mips/mips64/n64/nptl/libc.abilist | 4 ++
.../powerpc/powerpc32/nofpu/nptl/libc.abilist | 4 ++
.../linux/tile/tilegx/tilegx32/nptl/libc.abilist | 4 ++
.../linux/tile/tilegx/tilegx64/nptl/libc.abilist | 4 ++
.../unix/sysv/linux/tile/tilepro/nptl/libc.abilist | 4 ++
sysdeps/unix/sysv/linux/i386/nptl/libc.abilist | 4 ++
.../linux/powerpc/powerpc32/fpu/nptl/libc.abilist | 4 ++
.../sysv/linux/powerpc/powerpc64/nptl/libc.abilist | 4 ++
.../unix/sysv/linux/s390/s390-32/nptl/libc.abilist | 4 ++
.../unix/sysv/linux/s390/s390-64/nptl/libc.abilist | 4 ++
sysdeps/unix/sysv/linux/sh/nptl/libc.abilist | 4 ++
.../sysv/linux/sparc/sparc32/nptl/libc.abilist | 4 ++
.../sysv/linux/sparc/sparc64/nptl/libc.abilist | 4 ++
.../unix/sysv/linux/x86_64/64/nptl/libc.abilist | 4 ++
.../unix/sysv/linux/x86_64/x32/nptl/libc.abilist | 4 ++
41 files changed, 257 insertions(+), 21 deletions(-)
create mode 100644 debug/tst-chk7.c
create mode 100644 debug/tst-lfschk7.c