This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use integer constants in mpa.c
- From: Richard Henderson <rth at twiddle dot net>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 22 Mar 2013 07:24:47 -0700
- Subject: Re: [PATCH] Use integer constants in mpa.c
- References: <20130322100206 dot GJ2409 at spoyarek dot pnq dot redhat dot com>
On 2013-03-22 03:02, Siddhesh Poyarekar wrote:
- if (X[0] == ZERO)
+ if (__glibc_unlikely (X[0] == 0))
I'm not keen on all the branch markup. I can't believe it's all necessary. At
minimum please split that out to a separate patch, but I'd much rather do without.
*y = ZERO;
...
- z[2] = ZERO;
- z[3] = ZERO;
+ z[2] = 0;
+ z[3] = 0;
Is there a good reason to leave some ZERO uses and not others? I can't imagine
the literal 0 not be just as good everywhere, even in a floating-point context;
the compiler is quite good at converting constants at compile time...
Perhaps we should just eliminate these macros entirely?
r~