This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: libm-test: Properly wrap blocks consisting of several statements.
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Date: Thu, 21 Mar 2013 13:05:57 +0100
- Subject: Re: libm-test: Properly wrap blocks consisting of several statements.
- References: <874ng5t5go dot fsf at kepler dot schwinge dot homeip dot net>
On Thursday, March 21, 2013 11:25:27 Thomas Schwinge wrote:
> Hi!
>
> In math/libm-test.inc, when doing things like the following:
>
> if (SNAN_TESTS (FLOAT))
> TEST_f_f (gamma, snan_value, qnan_value, INVALID_EXCEPTION);
>
> ..., this is what appears in math/libm-test.c:
>
> if (SNAN_TESTS (FLOAT))
> signgam = 0;
> check_float ("gamma (sNaN) == qNaN", FUNC(gamma) (snan_value),
> qnan_value, 0, 0, INVALID_EXCEPTION);
>
> ..., which is not quite what I intended.
>
> Is the collowing patch OK? I didn't bother with proper indentation of
> the emitted statements, as the file is primarily meant for
> consumption by the compiler only.
Still, I would like to see proper intentation - as it's done already
today.
Could you enhance the patch, please? It looks fine otherwise,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126