This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping: [PATCH] Simplify macros in string/bits/string2.h.

On 03/11/2013 01:49 PM, Roland McGrath wrote:
>> On Mon, Mar 11, 2013 at 09:24:25AM -0700, Roland McGrath wrote:
>>> Try again with correct formatting of ChangeLog entries.
>> What about this?
>> 	* string/bits/string2.h (__BUILTIN_SINCE_GCC_3_2): Add.
>> 	(strchr) Unify pre and post gcc-3.2 versions.
>> 	(strcmp) Likewise.
>> 	(strcspn) Likewise.
>> 	(strspn) Likewise.
>> 	(strpbrk) Likewise.
> The format is still wrong and I've lost patience with describing the format
> to you over and over again.  Maybe someone else will help you.


The code in question is a macro, therefore the ChangeLog is
considerably more complicated by the conditionals.

Please see the conditional ChangeLog section in the 
GNU Coding Standard:

If I had to create a ChangeLog for this the first part would
look like this:

	* string/bits/string2.h [__GNU_C_PREREQ (3,2)]
	(__BUILTIN_SINCE_GCC_3_2): Define as call to __builtin_##fn.
	[!__GNU_C_PREREQ (3,2)]
	(__BUILTIN_SINCE_GCC_3_2): Define as call to fn.
	[!_HAVE_STRING_ARCH_strchr && __GNU_C_PREREQ (3,2)] (strchr): Remove.
	[!_HAVE_STRING_ARCH_strchr] (strchr): Define with __BUILTIN_SINCE_GCC_3_2.

Does that help?

Even I get these complex conditionals wrong sometimes ;-)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]