This is the mail archive of the
mailing list for the glibc project.
Re: Avoid backtrace tests matching filenames when searching forfunction names
> > Don't use implicit coercion to Boolean in the function.
> Done in this version.
> + if (p)
> + return strstr (p, name) != NULL;
> + else
> + return false;
return p != NULL && strstr (p, name) != NULL;
> > What's the reason for putting NO_INLINE on do_test?
> Generally trying to control what the sequence of functions should look
> like as much as possible, even though in fact it's not possible to get a
> name for do_test in the backtrace, so the testing stops before there.
There is no point in attempting to ensure there is a frame for do_test and
then not testing that there is one.
> The glibc build system - and most makefiles in general - wouldn't work in
> practice if the paths to either source or build trees contained a '(' or
> other characters with special meaning to the shell.
Granted. (And ( has special meaning to make, even.)