This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix tst-array{2,5} with --as-needed

From: Allan McRae <allan at archlinux dot org>
To: Carlos O'Donell <carlos at systemhalted dot org>
Cc: Adam Conrad <adconrad at 0c3 dot net>, libc-alpha at sourceware dot org
Date: Tue, 22 Jan 2013 13:47:19 +1000
Subject: Re: [PATCH] Fix tst-array{2,5} with --as-needed
References: <20130122033008.GJ29056@0c3.net> <CAE2sS1hofhzRB2+_PNKHZuApQDMnXoN9rf2wHpbfwLCc=0MO4Q@mail.gmail.com>

On 22/01/13 13:34, Carlos O'Donell wrote:
> On Mon, Jan 21, 2013 at 10:30 PM, Adam Conrad <adconrad@0c3.net> wrote:
>> Ubuntu's toolchain defaults to --as-needed.  tst-array2 and
>> tst-array5 fail unless built with --no-as-needed, so add it
>> to the Makefile.  Tested locally to DTRT.  Okay to commit?
>>
>> 2013-01-21  Adam Conrad  <adconrad@0c3.net>
>>
>>        * elf/Makefile (LDFLAGS-tst-array2): Add $(no-as-needed).
>>        (LDFLAGS-tst-array5): Likewise.
> 
> Why does it fail with --as-needed?
> 

This issue is essentially the same as [1] - although that disappeared
when some functions were moved from librt.

Then it was decided that adding $(no-as-needed) all over the place was
not the correct approach but rather to rearrange link command line.

[1] http://sourceware.org/ml/libc-alpha/2012-10/msg00190.html

Allan

Follow-Ups:
- Re: [PATCH] Fix tst-array{2,5} with --as-needed
  - From: Adam Conrad

References:
- [PATCH] Fix tst-array{2,5} with --as-needed
  - From: Adam Conrad
- Re: [PATCH] Fix tst-array{2,5} with --as-needed
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]