This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations

From: Jakub Jelinek <jakub at redhat dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, "Carlos O'Donell" <carlos at systemhalted dot org>, David Miller <davem at davemloft dot net>, roland at hack dot frob dot com, aj at suse dot com, libc-alpha at sourceware dot org
Date: Thu, 17 Jan 2013 18:25:10 +0100
Subject: Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
References: <20130116202029.641B32C0C3@topped-with-meat.com><CAMe9rOo-k0FScCzbN_o_d+rNwWb8tD+Q-WV2C5f9DxSTKfxQpw@mail.gmail.com><20130116203321.7715D2C0C3@topped-with-meat.com><20130116.154206.218500375113315270.davem@davemloft.net><50F76E66.10005@systemhalted.org><CAMe9rOpkL-PFeAr8u_RuWxSYEK+rfAbYFzf75QsOGpRFMVNZmQ@mail.gmail.com><20130117165310.GG26036@sunsite.ms.mff.cuni.cz><CAMe9rOrBja_w3te5CkLwjFsUXNAwvW6DedRqdYHVYwHfi3zUKQ@mail.gmail.com>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Thu, Jan 17, 2013 at 09:10:28AM -0800, H.J. Lu wrote:
> On Thu, Jan 17, 2013 at 8:53 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> > On Wed, Jan 16, 2013 at 08:32:54PM -0800, H.J. Lu wrote:
> >> I checked x86 size relocation support into binutils and
> >> pushed it to master branch in glibc.
> >
> > Please revert it, this should have never been a dynamic relocation.
> >
> 
> That is not true.  Please see binutils size relocation linker tests.
> 2 tests scan for run-time size relocation.

You've added a feature that is not really useful for asan, without
discussing it first.  So we just end up with dead code in both glibc and
gcc.

	Jakub

Follow-Ups:
- Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
  - From: H.J. Lu

References:
- Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
  - From: Roland McGrath
- Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
  - From: H.J. Lu
- Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
  - From: Roland McGrath
- Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
  - From: David Miller
- Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
  - From: Carlos O'Donell
- Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
  - From: H.J. Lu
- Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
  - From: Jakub Jelinek
- Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]