This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Implement x86 SIZE32/SIZE64 relocations
It's appropriate to make the elf.h change as soon as the names and numbers
are fixed by specification. The dynamic linker changes wait until binutils
support to actually generate the types is committed.
A branch is most useful for review purposes if it doesn't show interstitial
commits that won't (and shouldn't) ever be seen in the final commit to the
trunk. In your x86_64/dl-machine.h code, it's cleaner just to write the
implementation of each type once doing it one way. If that involves some
unnecessary casts for each type on the inversely-corresponding
configuration, that's better than having more #if in the code.