This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Use $(host-test-program-cmd) not $(test-program-cmd) for bug-setlocale1

The recent change

commit c34521ceac1ba7aee2afa06a883415605ba9e07c
Author: H.J. Lu <>
Date:   Thu Jan 10 14:15:49 2013 -0800

    Support run bug-setlocale1 directly

was incorrect for cross-testing because it used $(built-program-cmd)
(now $(test-program-cmd) after another commit) for a testcase execing
itself, when this needs $(host-built-program-cmd) (now
$(host-test-program-cmd)) to avoid running a test wrapper incorrectly
on the wrong system.  I've committed this patch as obvious to fix how
this test is run.  Tested with cross to powerpc-linux-gnu.

2013-01-14  Joseph Myers  <>

	* Makefile (bug-setlocale1-ARGS): Use $(host-test-program-cmd),
	not $(test-program-cmd).

diff --git a/localedata/Makefile b/localedata/Makefile
index 11a6a79..52c39b3 100644
--- a/localedata/Makefile
+++ b/localedata/Makefile
@@ -288,7 +288,7 @@ $(objpfx)mtrace-tst-leaks: $(objpfx)tst-leaks.out
 	$(common-objpfx)malloc/mtrace $(objpfx)tst-leaks.mtrace > $@
 bug-setlocale1-ENV = LOCPATH=$(common-objpfx)localedata
-bug-setlocale1-ARGS = -- $(test-program-cmd)
+bug-setlocale1-ARGS = -- $(host-test-program-cmd)
 bug-setlocale1-static-ENV = $(bug-setlocale1-ENV)
 bug-setlocale1-static-ARGS = $(bug-setlocale1-ARGS)
 tst-setlocale2-ENV = LOCPATH=$(common-objpfx)localedata

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]