This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2] scsi/sg.h: include stddef.h for size_t
On Mon, Jan 14, 2013 at 12:41 PM, Mike Frysinger <email@example.com> wrote:
> On Sunday 13 January 2013 17:41:34 Joseph S. Myers wrote:
>> On Sun, 13 Jan 2013, Mike Frysinger wrote:
>> > This header uses size_t but doesn't include stddef.h for it. So when
>> > packages happen to include this before any header that defines size_t,
>> > they get a build failure.
>> stddef.h defines offsetof; I don't see any good reason for that to be
>> defined by this header. If size_t is all that's wanted from stddef.h, I
>> think you should define __need_size_t before the #include to avoid
>> bringing in other extraneous definitions such as offsetof.
> seems like over kill considering we're talking about Linux-specific headers
> that cover kernel ABIs, but i don't care enough to fight over it
My preference is that this patch go in *as is*, even though a better QoI
would be to use __need_size_t, I don't see that we should wait for a
better solution. The header internally needs these types, and should
include the appropriate header.
Joseph, Were you blocking the checkin or are you merely stating an
opinion about QoI?