This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, mips, elf.h] Fix elf.h values for MIPS archs.

On Thu, 2013-01-10 at 14:56 -0800, Roland McGrath wrote:
> The whitespace on those lines was all wrong.  I committed a fix for that.
> Please send a new patch against the current tip of tree.
> The E_MIPS_* names are obsolete cruft and no new ones should be added,
> so leave those out.
> Thanks,
> Roland

I wonder if we should just delete the old ones completely.  Given how
long the values for MIPS32 and MIPS64 were wrong I don't think these
macros are used much.  Here is my latest patch based on ToT that does

2013-01-10  Steve Ellcey  <>

	* elf/elf.h (EF_MIPS_ARCH_32): Fix value.
	(EF_MIPS_ARCH_64): Fix value.
	(EF_MIPS_ARCH_32R2): New.
	(EF_MIPS_ARCH_64R2): New.
	(E_MIPS_ARCH_1): Remove.
	(E_MIPS_ARCH_2): Remove.
	(E_MIPS_ARCH_3): Remove.
	(E_MIPS_ARCH_4): Remove.
	(E_MIPS_ARCH_5): Remove.
	(E_MIPS_ARCH_32): Remove.
	(E_MIPS_ARCH_64): Remove.

diff --git a/elf/elf.h b/elf/elf.h
index 0731348..9db5d49 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -1388,18 +1388,10 @@ typedef struct
 #define EF_MIPS_ARCH_3		0x20000000 /* -mips3 code.  */
 #define EF_MIPS_ARCH_4		0x30000000 /* -mips4 code.  */
 #define EF_MIPS_ARCH_5		0x40000000 /* -mips5 code.  */
-#define EF_MIPS_ARCH_32		0x60000000 /* MIPS32 code.  */
-#define EF_MIPS_ARCH_64		0x70000000 /* MIPS64 code.  */
-/* The following are unofficial names and should not be used.  */
-#define E_MIPS_ARCH_1		EF_MIPS_ARCH_1
-#define E_MIPS_ARCH_2		EF_MIPS_ARCH_2
-#define E_MIPS_ARCH_3		EF_MIPS_ARCH_3
-#define E_MIPS_ARCH_4		EF_MIPS_ARCH_4
-#define E_MIPS_ARCH_5		EF_MIPS_ARCH_5
-#define E_MIPS_ARCH_32		EF_MIPS_ARCH_32
-#define E_MIPS_ARCH_64		EF_MIPS_ARCH_64
+#define EF_MIPS_ARCH_32		0x50000000 /* MIPS32 code.  */
+#define EF_MIPS_ARCH_64		0x60000000 /* MIPS64 code.  */
+#define EF_MIPS_ARCH_32R2	0x70000000 /* MIPS32r2 code.  */
+#define EF_MIPS_ARCH_64R2	0x80000000 /* MIPS64r2 code.  */
 /* Special section indices.  */

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]