This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][PPC] Remove unnecessary local variable mptwo

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: Richard Henderson <rth at twiddle dot net>, "Carlos O'Donell" <carlos at systemhalted dot org>, libc-alpha at sourceware dot org, rsa at us dot ibm dot com
Date: Fri, 11 Jan 2013 00:33:33 +0530
Subject: Re: [PATCH][PPC] Remove unnecessary local variable mptwo
References: <20130109114033.GC2692@spoyarek.pnq.redhat.com><50EEE333.7080304@systemhalted.org><50EEF6E9.9020601@twiddle.net><20130110180350.GJ2692@spoyarek.pnq.redhat.com><20130110180639.0E9252C0A8@topped-with-meat.com>

On Thu, Jan 10, 2013 at 10:06:39AM -0800, Roland McGrath wrote:
> It seems appropriate to check.  In many cases an initialized local like
> that gets folded into its uses and occupies no stack space and uses less
> code compared to the load from a global.

I just checked now and it's dead code; removing it makes absolutely no
difference.  The compiler somehow picked up the global variable all
along.

Siddhesh

References:
- [PATCH][PPC] Remove unnecessary local variable mptwo
  - From: Siddhesh Poyarekar
- Re: [PATCH][PPC] Remove unnecessary local variable mptwo
  - From: Carlos O'Donell
- Re: [PATCH][PPC] Remove unnecessary local variable mptwo
  - From: Richard Henderson
- Re: [PATCH][PPC] Remove unnecessary local variable mptwo
  - From: Siddhesh Poyarekar
- Re: [PATCH][PPC] Remove unnecessary local variable mptwo
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]