This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Sync with Linux 3.7


On 12/21/2012 05:41 PM, Roland McGrath wrote:
>> ok for 2.18?
> 
> OK, but as two separate commits.
> 
>> 	* sysdeps/gnu/netinet/tcp.h (TCPI_OPT_SYN_DATA)
>> 	(TCPI_OPT_ECN_SEEN): Define. Sync with Linux 3.7.
> 
> Two spaces between sentences.
> 
>> 	* elf/elf.h (NT_S390_TDB, NT_FILE, NT_SIGINFO): Define. New values
> 
> Likewise.
> 
>> +/* Note to userspace developers: size of NT_SIGINFO note may increase
>> +   in the future to accomodate more fields, don't assume it is
>> +   fixed!  */
>> +#define NT_SIGINFO      0x53494749
> 
> This is a kernel-centric comment.  The rest of this file doesn't talk about
> the details of the contents.  Just give it a simple comment like the
> others (and use tabs):

FWIW, I think the comment is bogus in the kernel too.  It goes back to a
version of the original kernel patch when NT_SIGINFO wasn't just a dump of
the siginfo_t binary object.

> 
> #define NT_SIGINFO	0x53494749	/* siginfo_t, size might increase */
> 
>> +#define NT_FILE         0x46494c45
> 
> Use tabs.  Give it a comment.  Is the format of the note defined as C
> structs somewhere?
> 
> 
> Thanks,
> Roland
> 


-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]