This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 01/15] Support multiarch under OS directory

On Thu, Jan 3, 2013 at 7:20 AM, Andreas Jaeger <> wrote:
> On 12/23/2012 04:02 AM, Andi Kleen wrote:
>> From: "H.J. Lu" <>
> Let's push this patch interdependent of the others in - but it needs a
> proper reasoning what it will do and why it's needed.
> Please explain what you want to achieve here,

configure was supposed to support multiarch directory
under sysdeps/unix/sysv/linux/x86_64, as m0sub and msub
used in directory scan:


But we never set m0sub and msub.  As the result, we never
check multiarch directory under OS directory.  My patch adds
the missing m0sub and msub. Ignoring white spaces, my patch is:

diff --git a/configure b/configure
index 8799b7d..bf73d05 100755
--- a/configure
+++ b/configure
@@ -4347,11 +4347,13 @@ sysnames_add_ons=
 for b in $base ''; do
   for m0 in $mach ''; do
+    for m0sub in $mach ''; do
       for v in /$vendor ''; do
   test "$v" = / && continue
   for o in /$ostry ''; do
     test "$o" = / && continue
     for m in $multi_arch_d $mach ''; do
+      for msub in $multi_arch_d $mach ''; do
         for d in $add_ons_pfx ''; do
      for a in $add_ons_sfx ''; do
        if test -n "$m0$m0sub$b$v$o$m$msub"; then
@@ -4384,6 +4386,8 @@ for b in $base ''; do
+  done

It is a correctness issue.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]