This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: PATCH: Use libc_ifunc_hidden_def in x86_64/gettimeofday.c

On 12/31/2012 05:44 PM, H.J. Lu wrote:
On Fri, Dec 14, 2012 at 9:22 AM, H.J. Lu <> wrote:

This patch uses libc_ifunc_hidden_def x86_64/gettimeofday.c.  OK for

Please explain next time why this is needed, this makes reviewing so much easier - and easy reviews are quick ;)


H.J. 2012-12-14 H.J. Lu <>

         * sysdeps/unix/sysv/linux/x86_64/gettimeofday.c: Use
diff --git a/sysdeps/unix/sysv/linux/x86_64/gettimeofday.c b/sysdeps/unix/sysv/linux/x86_64/gettimeofday.c
index d52f938..9af9316 100644
--- a/sysdeps/unix/sysv/linux/x86_64/gettimeofday.c
+++ b/sysdeps/unix/sysv/linux/x86_64/gettimeofday.c
@@ -36,11 +36,7 @@ gettimeofday_ifunc (void)
  asm (".type __gettimeofday, %gnu_indirect_function");

-/* This is doing "libc_hidden_def (__gettimeofday)" but the compiler won't
-   let us do it in C because it doesn't know we're defining __gettimeofday
-   here in this file.  */
-asm (".globl __GI___gettimeofday\n"
-     "__GI___gettimeofday = __gettimeofday");
+libc_ifunc_hidden_def (__gettimeofday)


This is fine since gettimeofday uses ifunc,

 Andreas Jaeger aj@{,} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]