Re: [PATCH 04/15] Convert pthread_rwlock_try(rd/wr)lock to prototypes

[Andreas Jaeger <aj at suse dot com>]

On 12/23/2012 04:02 AM, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Later patches include these files in sysdeps, and the sysdeps sub Makefiles
> make the compiler complain about non prototype functions. So change
> them to prototypes.
>
> 2012-12-09    <ak@linux.intel.com>
>
>          * nptl/pthread_rwlock_tryrdlock.c (__pthread_rwlock_tryrdlock):
>          Conver to prototype.

Typo: convert.
>          * nptl/pthread_rwlock_trywrlock.c (__pthread_rwlock_trywrlock): Dito.

We normally use Likewise instead of Dito.

The patch itself is fine.

Andi, shall I commit it for you?

Andreas

> ---
>   nptl/pthread_rwlock_tryrdlock.c |    3 +--
>   nptl/pthread_rwlock_trywrlock.c |    3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/nptl/pthread_rwlock_tryrdlock.c b/nptl/pthread_rwlock_tryrdlock.c
> index beaa970..25dc09f 100644
> --- a/nptl/pthread_rwlock_tryrdlock.c
> +++ b/nptl/pthread_rwlock_tryrdlock.c
> @@ -22,8 +22,7 @@
>
>
>   int
> -__pthread_rwlock_tryrdlock (rwlock)
> -     pthread_rwlock_t *rwlock;
> +__pthread_rwlock_tryrdlock (pthread_rwlock_t *rwlock)
>   {
>     int result = EBUSY;
>
> diff --git a/nptl/pthread_rwlock_trywrlock.c b/nptl/pthread_rwlock_trywrlock.c
> index 92750b8..be5af28 100644
> --- a/nptl/pthread_rwlock_trywrlock.c
> +++ b/nptl/pthread_rwlock_trywrlock.c
> @@ -22,8 +22,7 @@
>
>
>   int
> -__pthread_rwlock_trywrlock (rwlock)
> -     pthread_rwlock_t *rwlock;
> +__pthread_rwlock_trywrlock (pthread_rwlock_t *rwlock)
>   {
>     int result = EBUSY;


--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126