This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH/RFC] Keep exported _nl_default_dirname constant whenprefix changes
- From: Jonathan Nieder <jrnieder at gmail dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 11 Dec 2012 03:30:53 -0800
- Subject: Re: [PATCH/RFC] Keep exported _nl_default_dirname constant whenprefix changes
- References: <20121211111200.GD6136@elie.Belkin><mvmsj7crg64.fsf@hawking.suse.de>
Andreas Schwab wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>> diff --git a/intl/Versions b/intl/Versions
>> index d76982db..4491e595 100644
>> --- a/intl/Versions
>> +++ b/intl/Versions
>> @@ -1,7 +1,14 @@
>> +%define SHARED
>> +%include <shlib-compat.h>
>> +
>> libc {
>> GLIBC_2.0 {
>> # global variables
>> - _nl_msg_cat_cntr; _nl_default_dirname; _nl_domain_bindings;
>> + _nl_msg_cat_cntr;
>> +%if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_17)
>> + _nl_default_dirname;
>> +%endif
>
> Do you need this? AFAIU if the symbol is not defined (ie. min-ABI is
> 2.17) it is just ignored.
I think you're right. The only Versions files (hurd/Versions and
mach/Versions) that do this kind of thing also have negated blocks
("%if !SHLIB_COMPAT (...)") so presumably they're doing something more
complicated.
Thanks. The next version will leave intl/Versions alone.