This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: BZ #14664: changing prefix breaks "make check-abi-libc"


> There are already some explanations in comments in the Versions files, 
> although those explanations are not necessarily currently accurate and may 
> not be sufficient justification for something being in the public ABI 
> (e.g. intl/Versions just says "global variables" for _nl_*, which doesn't 
> justify being *public* global variables).

Yes, those are inadequate and also not a central list like I proposed.
But meaningful comments in Versions files are certainly worthwhile too.

> (In checking for such comments I noticed
> 
>     # functions used in inline functions or macros
>     __strto*_internal;
> 
> and similar in wcsmbs/Makefile - such use of "*" in symbol names in 
> Versions files seems a bad idea, all the public functions should be listed 
> explicitly.)

Agreed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]