Re: [PATCH] BZ #14831: Segfault in _dl_profile_fixup with IRELATIVE and LD_AUDIT

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

On Wed, 14 Nov 2012 15:50:55 -0800, "H.J. Lu" <hjl.tools@gmail.com> wrote:
> Andreas, Kaz, Thomas, could you
> please define ELF_MACHINE_RUNTIME_FIXUP_PARAMS for
> m68k and sh since they are the only targets which define
> ELF_MACHINE_RUNTIME_FIXUP_ARGS.

Andreas already pushed the obvious change for m68k in commit
e510ab5efff3450b723dbe71734e8b22be14d1c6, and I now pushed the following
as commit d072f3f7724d85ceaf230806660235f0cf2f9c3b.

I wonder however, why you didn't simply do (or at least propose) theses
trivial changes as part of your patch -- surely you must already have had
analyzed the situation when doing your changes -- and instead committed a
patch that made the sources unbuildable for m68k and SH, which is against
current practice, as far as I know?

	* sysdeps/sh/dl-machine.h (ELF_MACHINE_RUNTIME_FIXUP_PARAMS): New
	macro.

diff --git sysdeps/sh/dl-machine.h sysdeps/sh/dl-machine.h
index 53656af..1bb5d15 100644
--- sysdeps/sh/dl-machine.h
+++ sysdeps/sh/dl-machine.h
@@ -116,6 +115,7 @@ elf_machine_runtime_setup (struct link_map *l, int lazy, int profile)
 }
 
 #define ELF_MACHINE_RUNTIME_FIXUP_ARGS int plt_type
+#define ELF_MACHINE_RUNTIME_FIXUP_PARAMS plt_type
 
 /* Mask identifying addresses reserved for the user program,
    where the dynamic linker should not map anything.  */


GrÃÃe,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature