This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add ldconfig cache tag handling for AArch64
On Thu, Nov 15, 2012 at 8:39 PM, Steve McIntyre
<steve.mcintyre@linaro.org> wrote:
> On Wed, Nov 14, 2012 at 11:00:08PM -0500, Carlos O'Donell wrote:
>>On Wed, Nov 14, 2012 at 8:52 PM, Steve McIntyre
>><steve.mcintyre@linaro.org> wrote:
>>> Hi folks,
>>>
>>> Initial core code for AArch64 - allocate a tag number
>>> FLAG_AARCH64_LIB64 and add code to handle it in ldconfig. Code to
>>> follow on libc-ports to handle parsing ELF flags and using the new
>>> tag. Follows on from the previous armhf patch in the same area.
>>>
>>> =====================================================================
>>
>>Some of the same nits I mentioned with your other patch apply here,
>>repeated for the sake of posterity.
>
> Yup.
>
>>Does this change potentially impact other distributions?
>
> AArch64 is only just going into glibc at this point (as you know!); to
> the best of my knowledge all the distros are barely doing initial
> bringup right now. I don't expect this to affect anybody right now,
> but the sooner we get this in the easier it will be for everybody. :-)
Agreed, just checking.
>>> Add ldconfig cache tag handling for AArch64
>>>
>>> * sysdeps/generic/ldconfig.h (FLAG_AARCH64_LIB64): New macro.
>>> * elf/cache.c (print_entry): Print appropriate message for cache
>>> entries tagged with FLAG_AARCH64_LIB64.
>>
>>Overly verbose. Suggest `Print ",64bit" for FLAG_AARCH64_LIB64.'
>
> Yup.
>
>>> diff --git a/elf/cache.c b/elf/cache.c
>>> index 49aa9a6..e8a4724 100644
>>> --- a/elf/cache.c
>>> +++ b/elf/cache.c
>>
>>Update and merge copyright years.
>
> Already done in the ARM h-f patch that this follows.
>
> I've also switched from ",64bit" to ",AArch64" as hinted by Marcus.
>
> Patch v2:
>
> =====================================================================
> Add ldconfig cache tag handling for AArch64
>
> * sysdeps/generic/ldconfig.h (FLAG_AARCH64_LIB64): New macro.
> * elf/cache.c (print_entry): Print ",AArch64" for
> FLAG_AARCH64_LIB64.
>
> Signed-off-by: Steve McIntyre <steve.mcintyre@linaro.org>
> ---
> ChangeLog | 6 ++++++
> elf/cache.c | 3 +++
> sysdeps/generic/ldconfig.h | 1 +
> 3 files changed, 10 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index 885587c..ad8f145 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,9 @@
> +2012-11-16 Steve McIntyre <steve.mcintyre@linaro.org>
> +
> + * sysdeps/generic/ldconfig.h (FLAG_AARCH64_LIB64): New macro.
> + * elf/cache.c (print_entry): Print ",AArch64" for
> + FLAG_AARCH64_LIB64.
> +
> 2012-11-15 Steve McIntyre <steve.mcintyre@linaro.org>
>
> * sysdeps/generic/ldconfig.h (FLAG_ARM_LIBHF): New macro.
> diff --git a/elf/cache.c b/elf/cache.c
> index 08ccd2e..71d2da9 100644
> --- a/elf/cache.c
> +++ b/elf/cache.c
> @@ -97,6 +97,9 @@ print_entry (const char *lib, int flag, unsigned int osversion,
> case FLAG_ARM_LIBHF:
> fputs (",hard-float", stdout);
> break;
> + case FLAG_AARCH64_LIB64:
> + fputs (",AArch64", stdout);
> + break;
> case 0:
> break;
> default:
> diff --git a/sysdeps/generic/ldconfig.h b/sysdeps/generic/ldconfig.h
> index 1c8cc9d..abf3a9a 100644
> --- a/sysdeps/generic/ldconfig.h
> +++ b/sysdeps/generic/ldconfig.h
> @@ -35,6 +35,7 @@
> #define FLAG_MIPS64_LIBN64 0x0700
> #define FLAG_X8664_LIBX32 0x0800
> #define FLAG_ARM_LIBHF 0x0900
> +#define FLAG_AARCH64_LIB64 0x0a00
>
> /* Name of auxiliary cache. */
> #define _PATH_LDCONFIG_AUX_CACHE "/var/cache/ldconfig/aux-cache"
> --
This looks good to me.
Do you need me to check this in for you *after* the FLAG_ARM_LIBHF changes?
Cheers,
Carlos.