Re: PATCH: Remove ${SHELL} from convdata/tst-tables.sh/iconvdata/tst-table.sh

["Carlos O'Donell" <carlos at systemhalted dot org>]

On Fri, Oct 26, 2012 at 8:35 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>         *  iconvdata/tst-table.sh: Remove ${SHELL}.
>         *  iconvdata/tst-tables.sh: Likewise.

This looks good to me.

I assume the original patch was from an era where glibc
developers uploaded patches to reduce bandwidth usage. Where
users would apply patches to base revisions to get the latest
development release. That definitely doesn't apply today.

I'm not at all worried about the need to chmod files after
patching. This has always been my expected behaviour.

I also don't want to pass around that many patches (except
for review), instead I'd want git-pull requests from feature
branches to become more the norm.

> ---
> diff --git a/iconvdata/tst-table.sh b/iconvdata/tst-table.sh
> index 14ab196..5283ad5 100755
> --- a/iconvdata/tst-table.sh
> +++ b/iconvdata/tst-table.sh
> @@ -35,7 +35,7 @@ export LC_ALL
>  set -e
>
>  # Get the charmap.
> -${SHELL} tst-table-charmap.sh ${charmap:-$charset} \
> +./tst-table-charmap.sh ${charmap:-$charset} \
>    < ../localedata/charmaps/${charmap:-$charset} \
>    > ${objpfx}tst-${charset}.charmap.table
>  # When the charset is GB18030, truncate this table because for this encodi=
> ng,
> diff --git a/iconvdata/tst-tables.sh b/iconvdata/tst-tables.sh
> index eaf84dc..77d9d18 100755
> --- a/iconvdata/tst-tables.sh
> +++ b/iconvdata/tst-tables.sh
> @@ -262,7 +262,7 @@ while read charset charmap; do
>    if test "$charset" =3D GB18030; then echo "This might take a while" 1>&2=
> ; fi
>    case ${charset} in \#*) continue;; esac
>    echo -n "Testing ${charset}" 1>&2
> -  if ${SHELL} tst-table.sh ${common_objpfx} ${objpfx} "${run_program_prefi=
> x}" \
> +  if ./tst-table.sh ${common_objpfx} ${objpfx} "${run_program_prefix}" \
>        ${charset} ${charmap} < /dev/null; then
>      echo 1>&2
>    else