This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #11741] printf should return negative value on I/O error


Siddhesh Poyarekar <siddhesh@redhat.com> writes:

> diff --git a/libio/iopadn.c b/libio/iopadn.c
> index 7e37450..62fd62c 100644
> --- a/libio/iopadn.c
> +++ b/libio/iopadn.c
> @@ -59,7 +59,7 @@ _IO_padn (fp, pad, count)
>        w = _IO_sputn (fp, padptr, PADSIZE);
>        written += w;
>        if (w != PADSIZE)
> -	return written;
> +	return w <= 0 ? w :written;

What's the significance of w == 0?  sputn should return either the
amount of written bytes or EOF.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]