This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] epoll: Support for disabling items, and a self-testapp.
- From: Andrew Morton <akpm at linux-foundation dot org>
- To: mtk dot manpages at gmail dot com
- Cc: "Paton J. Lewis" <palewis at adobe dot com>, Alexander Viro<viro at zeniv dot linux dot org dot uk>, Jason Baron <jbaron at redhat dot com>,linux-fsdevel at vger dot kernel dot org, linux-kernel at vger dot kernel dot org, Paul Holland<pholland at adobe dot com>, Davide Libenzi <davidel at xmailserver dot org>,libc-alpha at sourceware dot org, Linux API <linux-api at vger dot kernel dot org>
- Date: Wed, 17 Oct 2012 16:30:04 -0700
- Subject: Re: [PATCH v2] epoll: Support for disabling items, and a self-testapp.
- References: <1345756535-8372-1-git-send-email-palewis@adobe.com><CAKgNAkg0R2LwfpF8beCkawTfPu7oj_DDaDxf2VJ+xB6UTgRSaw@mail.gmail.com>
On Tue, 16 Oct 2012 17:12:57 +0200
"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> wrote:
> On Thu, Aug 23, 2012 at 11:15 PM, Paton J. Lewis <palewis@adobe.com> wrote:
> > From: "Paton J. Lewis" <palewis@adobe.com>
> >
> > Enhanced epoll_ctl to support EPOLL_CTL_DISABLE, which disables an epoll item.
> > If epoll_ctl doesn't return -EBUSY in this case, it is then safe to delete the
> > epoll item in a multi-threaded environment. Also added a new test_epoll self-
> > test app to both demonstrate the need for this feature and test it.
>
> (There's a lot of background missing from this version of the patch
> that was included in the previous version
> [http://thread.gmane.org/gmane.linux.kernel/1311457]. It helps to
> include the full rationale with a revised patch--best not to assume
> that someone has the context of past mails when reading a revised
> patch.)
>
> I've taken a look at this patch as it currently stands in 3.7-rc1, and
> done a bit of testing. (By the way, the test program
> tools/testing/selftests/epoll/test_epoll.c does not compile...)
Thanks for this. You raise significant issues. If we can't get these
fully resolved over the next month or so, we should revert the patch so
this new API doesn't get released in 3.7. I have queued a patch to do
this and shall maintain it while I watch developments...