This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] Add debug IFUNC tests
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 15 Oct 2012 14:29:12 -0700
- Subject: Re: [PATCH 1/3] Add debug IFUNC tests
- References: <20121012000439.GA27624@gmail.com><507BC92A.7060403@suse.com>
On Mon, Oct 15, 2012 at 1:28 AM, Andreas Jaeger <aj@suse.com> wrote:
> On 10/12/2012 02:04 AM, H.J. Lu wrote:
>>
>> This patch adds debug IFUNC tests. OK to install?
>>
>> Thanks.
>>
>>
>> H.J.
>> ---
>> ChangeLog | 7 +++++++
>> debug/Makefile | 4 ++++
>> debug/test-stpcpy_chk-ifunc.c | 2 ++
>> debug/test-stpcpy_chk.c | 3 ++-
>> debug/test-strcpy_chk-ifunc.c | 2 ++
>> debug/test-strcpy_chk.c | 3 ++-
>> 6 files changed, 19 insertions(+), 2 deletions(-)
>> create mode 100644 debug/test-stpcpy_chk-ifunc.c
>> create mode 100644 debug/test-strcpy_chk-ifunc.c
>>
>> * debug/Makefile (ifunc-tests): New variable.
>> (tests-ifunc): Likewise.
>> * debug/test-stpcpy_chk.c (TEST_NAME): New macro.
>> * debug/test-strcpy_chk.c (TEST_NAME): Likewise.
>> * debug/test-stpcpy_chk-ifunc.c: New file.
>> * debug/test-strcpy_chk-ifunc.c: Likewise.
>>
>> diff --git a/debug/Makefile b/debug/Makefile
>> index ae5b674..426989b 100644
>> --- a/debug/Makefile
>> +++ b/debug/Makefile
>> @@ -126,6 +126,10 @@ tests = backtrace-tst tst-longjmp_chk tst-chk1
>> tst-chk2 tst-chk3 \
>> tst-chk4 tst-chk5 tst-chk6 tst-lfschk4 tst-lfschk5 tst-lfschk6 \
>> tst-longjmp_chk2
>>
>> +ifunc-tests = test-stpcpy_chk test-strcpy_chk
>> +tests-ifunc = $(addsuffix -ifunc,$(ifunc-tests))
>> +tests += $(tests-ifunc)
>> +
>> extra-libs = libSegFault libpcprofile
>> extra-libs-others = $(extra-libs)
>>
>> diff --git a/debug/test-stpcpy_chk-ifunc.c b/debug/test-stpcpy_chk-ifunc.c
>> new file mode 100644
>> index 0000000..cf86bc1
>> --- /dev/null
>> +++ b/debug/test-stpcpy_chk-ifunc.c
>> @@ -0,0 +1,2 @@
>> +#define TEST_IFUNC 1
>> +#include "test-stpcpy_chk.c"
>> diff --git a/debug/test-stpcpy_chk.c b/debug/test-stpcpy_chk.c
>> index f7f9a54..8e2d2d9 100644
>> --- a/debug/test-stpcpy_chk.c
>> +++ b/debug/test-stpcpy_chk.c
>> @@ -1,5 +1,5 @@
>> /* Test and measure stpcpy checking functions.
>> - Copyright (C) 1999, 2002, 2004 Free Software Foundation, Inc.
>> + Copyright (C) 1999-2012 Free Software Foundation, Inc.
>> This file is part of the GNU C Library.
>> Written by Jakub Jelinek <jakub@redhat.com>, 1999.
>>
>> @@ -19,6 +19,7 @@
>>
>> #define STRCPY_RESULT(dst, len) ((dst) + (len))
>> #define TEST_MAIN
>> +#define TEST_NAME "stpcpy_chk"
>> #include "../string/test-string.h"
>>
>> extern void __attribute__ ((noreturn)) __chk_fail (void);
>> diff --git a/debug/test-strcpy_chk-ifunc.c b/debug/test-strcpy_chk-ifunc.c
>> new file mode 100644
>> index 0000000..fff7234
>> --- /dev/null
>> +++ b/debug/test-strcpy_chk-ifunc.c
>> @@ -0,0 +1,2 @@
>> +#define TEST_IFUNC 1
>> +#include "test-strcpy_chk.c"
>
>
>
> Here my comment from your second patch applies as well - shouldn't this have
> a copyright plate and a short description?
>
Is this an OK to install if copyright and short description are added?
--
H.J.