This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Check for overflow in __alloc_dir

From: Roland McGrath <roland at hack dot frob dot com>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Fri, 12 Oct 2012 10:57:35 -0700 (PDT)
Subject: Re: [PATCH] Check for overflow in __alloc_dir
References: <5076E2A6.4040406@redhat.com><20121011201741.0EEA42C0BB@topped-with-meat.com><50780D4E.8020809@redhat.com><20121012145412.631DD2C0CF@topped-with-meat.com><50782FFE.2000109@redhat.com>

> On 10/12/2012 04:54 PM, Roland McGrath wrote:
> > Use a macro for the constant and give it a comment about the choice of value.
> > Don't ignore a large st_blksize, just use MAX (st_blksize, MAX_ALLOCATION).
> 
> Sorry, I don't understand.  Do you mean MIN (st_blksize, MAX_ALLOCATION)?

Yes, sorry.

Follow-Ups:
- Re: [PATCH] Check for overflow in __alloc_dir
  - From: Florian Weimer

References:
- [PATCH] Check for overflow in __alloc_dir
  - From: Florian Weimer
- Re: [PATCH] Check for overflow in __alloc_dir
  - From: Roland McGrath
- Re: [PATCH] Check for overflow in __alloc_dir
  - From: Florian Weimer
- Re: [PATCH] Check for overflow in __alloc_dir
  - From: Roland McGrath
- Re: [PATCH] Check for overflow in __alloc_dir
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]