This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Don't include link-libc-static in +link-static-before-libc
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Wed, 10 Oct 2012 20:28:17 +0000
- Subject: Don't include link-libc-static in +link-static-before-libc
When I split +link-static-before-libc out of +link-static, I
mistakenly left $(link-libc-static) in the definition of
$(+link-static-before-libc). This means that $(link-libc-static)
unnecessarily appears twice in link commands - and also means that
static tests get wrongly linked with $(link-libc-static) in addition
to $(link-libc-static-tests) (so using architecture-specific
$(static-gnulib-arch), which should only be used for installed
programs to avoid problem dependencies in bootstrapping, not to link
tests).
This patch fixes this in the obvious way. Tested x86_64 (and also ARM
to verify that libgcc-stubs.a is no longer being used inappropriately
for tests).
2012-10-10 Joseph Myers <joseph@codesourcery.com>
* Makeconfig (+link-static-before-libc): Don't include
$(link-static-libc).
diff --git a/Makeconfig b/Makeconfig
index 6a54bf3..f451ec2 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -434,7 +434,7 @@ ifndef +link-static
$(start-installed-name))\
$(+preinit) $(link-extra-libs-static) \
$(common-objpfx)libc% $(+postinit),$^) \
- $(link-extra-libs-static) $(link-libc-static)
+ $(link-extra-libs-static)
+link-static-after-libc = $(+postctorT) $(+postinit)
+link-static = $(+link-static-before-libc) $(link-libc-static) \
$(+link-static-after-libc)
--
Joseph S. Myers
joseph@codesourcery.com