This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Link dynamic tests with newly built glibc


On Tue, 9 Oct 2012, H.J. Lu wrote:

> On Tue, Oct 09, 2012 at 04:51:16PM +0000, Joseph S. Myers wrote:
> > On Tue, 9 Oct 2012, H.J. Lu wrote:
> > 
> > > Thanks for explanation.  Then, we need test-program-prefix and
> > > test-program-cmd for both static and dynamic tests.
> > 
> > Yes, for full cross testing support we need that.  Of course existing 
> > static tests don't necessarily do anything special like that, and various 
> > .sh files don't use any existing abstraction such as run-program-prefix 
> > but instead hardcode such things as "${elf_objpfx}${rtld_installed_name} 
> > --library-path ${library_path}".  I think removing that sort of hardcoding 
> > is fine, and I don't think your patch needs to add anything new for static 
> > tests where you aren't otherwise changing anything - I just think that in 
> > places where you are removing an existing abstraction such as 
> > run-program-prefix or built-program-cmd, replacing it with a new 
> > abstraction is better - it makes things simpler for when I contribute 
> > cross-test support (presuming that's after your patch goes in).
> > 
> 
> Here is the updated patch with test-program-prefix/test-program-cmd.
> OK to install?

I have not reviewed the substance of this patch, but FWIW I have no 
objections to this version from the viewpoint of not making it any harder 
to add cross-test support.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]