This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][BZ #14417] Unlock mutex before going back to waitingfor PI mutexes
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Torvald Riegel <triegel at redhat dot com>, libc-alpha at sourceware dot org
- Date: Wed, 3 Oct 2012 23:10:55 +0530
- Subject: Re: [PATCH v2][BZ #14417] Unlock mutex before going back to waitingfor PI mutexes
- References: <20120921195115.2319b183@spoyarek><1348943552.3374.5816.camel@triegel.csb><20121003160106.18c5b1e4@spoyarek><506C751C.1080903@redhat.com>
On Wed, 03 Oct 2012 11:25:48 -0600, Jeff wrote:
> This looks good. My brain is hurting from reading too much assembly
> code today. It kept looking to me like the pi-requeued flag as
> uninitialized in the i386 versions, but that was an artifact of
> mostly looking at the diffs. Once I referred back to the original it
> was pretty obvious what was happening.
>
> FWIW, I haven't seen any complaints since this went into rawhide.
Thanks, I'll check this in on Friday if there are no objections till
then. As for the question of whether or not to abort, we could take it
up as a separate issue since there will have to be similar validation
for the normal FUTEX_WAIT.
Regards,
Siddhesh