Re: [PATCH] nscd: fix compilation flags

[Mike Frysinger <vapier at gentoo dot org>]

On Monday 01 October 2012 18:50:56 Dmitry V. Levin wrote:
> Commit 61653dfb81b776bb72ce4304175b861d77c357a8 added support for
> compilers predefining _FORTIFY_SOURCE by adding -U_FORTIFY_SOURCE to
> CPPFLAGS for these compilers, but that change doesn't work quite well in
> case of nscd: its Makefile sets _FORTIFY_SOURCE using CFLAGS instead of
> CPPFLAGS and, thanks to compilation rules defined in Makerules, CPPFLAGS
> are passed to compiler after CFLAGS, resulting to a build with
> _FORTIFY_SOURCE turned off.

LGTM

independent but related, i wonder about nscd_helper.c nscd_getserv_r.c 
nscd_netgroup.c ... shouldn't they also be listed ?  should we be able to 
express CFLAGS/CPPFLAGS via the active directory so that we don't have this 
out-of-sync behavior ?  CFLAGS-nscd/ rather than nscd-cflags so that all files 
automatically get built with it ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.