This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC - Add a function to read the Time Base frequency
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: "Carlos O'Donell" <carlos at systemhalted dot org>
- Cc: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Tue, 25 Sep 2012 15:09:30 -0500
- Subject: Re: [PATCH] PowerPC - Add a function to read the Time Base frequency
- References: <1345833351-10398-1-git-send-email-tuliom@linux.vnet.ibm.com><5038D642.9070500@systemhalted.org><1348592607.8661.2.camel@localhost.localdomain><CAE2sS1hdWQg9SB=YHPHviPgAsu2DFh0wv4K+vAYA-=FCKdO7fw@mail.gmail.com>
On Tue, Sep 25, 2012 at 2:31 PM, Carlos O'Donell
<carlos@systemhalted.org> wrote:
> On Tue, Sep 25, 2012 at 1:03 PM, Ryan Arnold <rsa@us.ibm.com> wrote:
>>> This looks good to me, I don't see anything wrong.
>>>
>>> Thanks for adding a testcase *and* documentation!
>>>
>>> Ryan should review this as power maintainer.
>>
>> I'm going to commit this since there were no objections. I do remain
>> concerned about including the __get_clockfreq object code in libc only
>> for PowerPC, but I'm fine with it if others are not concerned.
>
> Could you please expand on your concerns and include an example situation?
>
> Cheers,
> Carlos.
This fragment in sysdeps/unix/sysv/linux/powerpc/Makefile:
+ifeq ($(subdir),misc)
+sysdep_headers += bits/ppc.h
+sysdep_routines += get_clockfreq get_timebase_freq
+tests += test-gettimebasefreq
+endif
Adds get_clockfreq to sysdep_routines which then includes the
get_clockfreq object code into libc.
Normally this object code is only included in librt via:
rt/Makefile:clock-routines := get_clockfreq
So PowerPC will be the only architecture where this is built into in
libc. This really isn't much of an issue, especially since it's just
a read from the vDSO.
Ryan