This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE (take 2)

From: Carlos O'Donell <carlos_odonell at mentor dot com>
To: Marek Polacek <polacek at redhat dot com>
Cc: Roland McGrath <roland at hack dot frob dot com>, Andreas Schwab<schwab at linux-m68k dot org>, <libc-alpha at sourceware dot org>, libc-ports<libc-ports at sourceware dot org>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, AndreasKrebbel <krebbel at linux dot vnet dot ibm dot com>, David Miller <davem at davemloft dot net>
Date: Wed, 19 Sep 2012 11:03:58 -0400
Subject: Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE (take 2)
References: <20120917141912.GE1265@redhat.com> <m2y5k81xkt.fsf@igel.home> <20120917153457.GG1265@redhat.com> <20120917192509.1C35D2C08B@topped-with-meat.com> <20120917195307.GH1265@redhat.com> <20120917200130.704C42C08B@topped-with-meat.com> <20120918082118.GI1265@redhat.com> <20120918170645.B76D72C0A4@topped-with-meat.com> <5058C40D.9060301@mentor.com> <20120919115844.GL1265@redhat.com>

On 9/19/2012 7:58 AM, Marek Polacek wrote:
> On Tue, Sep 18, 2012 at 02:57:17PM -0400, Carlos O'Donell wrote:
>> On 9/18/2012 1:06 PM, Roland McGrath wrote:
>>> That looks fine to me, though I am having second thoughts about the exact
>>> choice of name.  SYMBOL_SIZE doesn't really communicate that it computes
>>> based on ., i.e. that the placement of the macro relative to assembly code
>>> following the symbol is crucial.  Good names are not coming to mind just now.
>>
>> Imply that it's computed: SYMBOL_CALC_SIZE?
>>
>> Imply that it's positional: SYMBOL_HERE_SIZE?
> 
> Or what about 'COMPUTE_SYMBOL_SIZE' or 'SYMBOL_SIZE_EXPR' or just
> 'SIZE_EXPR'?  I tried to find something similar in binutils and kernel, but they
> aren't using any kind of macro for this.

I like SIZE_EXPR, and suggest we use *_EXPR to describe macros with positional
parameters that might change if moved.

Cheers,
Carlos.
-- 
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026

References:
- [PATCH] Get rid of ASM_SIZE_DIRECTIVE
  - From: Marek Polacek
- Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
  - From: Andreas Schwab
- Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
  - From: Marek Polacek
- Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
  - From: Roland McGrath
- Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
  - From: Marek Polacek
- Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
  - From: Roland McGrath
- Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE (take 2)
  - From: Marek Polacek
- Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE (take 2)
  - From: Roland McGrath
- Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE (take 2)
  - From: Carlos O'Donell
- Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE (take 2)
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]