This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] [BZ #14579] rtld: limit self loading check to normal mode only

> +	$(SHELL) -e $^ > $@

If you want -e behavior, it's better to put 'set -e' inside the script so
it's self-contained rather than implicitly expecting an unusual invocation.

> +echo '# normal mode'
> +$rtld $rtld 2>&1 && rc=0 || rc=$?

This is a strange formulation and only necessary because of -e.  I don't
see what -e is buying you at all.  Just drop -e and write:
	$rtld $rtld 2>&1
	test $? -le 127 || result=1


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]