This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch][BZ 14583] Fix prototype of sigsetjmp in pthread.h
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 14 Sep 2012 10:37:25 -0700 (PDT)
- Subject: Re: [Patch][BZ 14583] Fix prototype of sigsetjmp in pthread.h
- References: <505369A3.2090104@redhat.com>
The declaration is necessary there because the pthread_cleanup_push macro
uses the function. <pthread.h> is not allowed to include <setjmp.h>, hence
the duplication. You should make the prototype match exactly, i.e. [1] vs *.
It might be nice to avoid the duplication by having a common bits/ header
that holds that declaration. But it seems like overkill for the single
declaration (which is really all pthread.h needs).
Thanks,
Roland