This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Making getenv more multi-threading--robust?
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Stephan Bergmann <sbergman at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 13 Sep 2012 10:03:50 -0700 (PDT)
- Subject: Re: Making getenv more multi-threading--robust?
- References: <5051BBEF.4080401@redhat.com>
POSIX does not require getenv vs setenv to be thread-safe, but Solaris
documents it as being thread-safe. So I think it's a reasonable change.
File a bug in bugzilla about it first.
Put the definition of the lock in getenv.c, so that when linking
statically, using getenv does not force setenv to be linked in.
getenv.c is already not intended to be built outside libc, so there is no
need for #ifdef _LIBC in there. setenv.c is shared with gnulib (though
they are out of synch), so maintaining its existing conditionalization is
appropriate.
Thanks,
Roland