This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Run tst-fopenloc if $(build-shared) is yes
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Mon, 10 Sep 2012 15:31:17 +0200
- Subject: Re: [PATCH] Run tst-fopenloc if $(build-shared) is yes
- References: <20120910132435.GB13276@intel.com>
On Monday, September 10, 2012 06:24:35 H.J. Lu wrote:
> Hi,
>
> tst-fopenloc depends on shared localedata objects and
> tst-fopenloc.check depends on tst-fopenloc. This patch enables them
> only if $(build-shared) is yes. OK to install.
We haven't done this in the past but since you're touching all of this,
a suggestion from my side: Add to each of these Makefile an explanation
why tests are disabled.
This is even not clear from your changelog, it only says "Add tst-
fopenloc" - I suggest to say "Add test-fopenloc since it depends on
shared localedata objects."
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126