This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mallopt indentation bug?

On Wed, Sep 5, 2012 at 7:47 PM, Alexandre Oliva <aoliva@redhat.com> wrote:
> On Sep  5, 2012, "Carlos O'Donell" <carlos_odonell@mentor.com> wrote:
>
>>>> +++ b/malloc/malloc.c
>
>> Merge copyright years.
>
> This file had already had them merged.
>
> Others I've just modified hadn't.  Fixed with the second patch below.

Thanks!

>> Alexandre, Could you please also fix the indentation for M_MMAP_MAX?
>
> I generally don't like to make gratuitous whitespace changes when not
> touching the actual code; they just make merges harder.

Certainly, a separate patch is fine.

> Now, since I'm about to touch the code there with one of the proposed
> probes, I'm checking this in, and adjusting the probe patch to match.

FAOD both of your patches look fine to me.

Cheers,
Carlos.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]