This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Require gawk >= 3.0


On Sat, Sep 1, 2012 at 3:36 AM, Allan McRae <allan@archlinux.org> wrote:
> We use GNU awk extensions and recommend using at least version 3.0 in
> the INSTALL file, so test for it.
>
>
> 2012-09-01  Allan McRae  <allan@archlinux.org>
>
>         [BZ #13412]
>         * configure.in (AWK): Require gawk version 3.0 or later.
>         * configure: Regenerated.
>
>
> diff --git a/configure.in b/configure.in
> index a5d9dea..7de4b09 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -926,6 +926,9 @@ AC_CHECK_PROG_VER(SED, sed, --version,
>    [GNU sed[^0-9]* \([0-9]*\.[0-9.]*\)],
>    [3.0[2-9]*|3.[1-9]*|[4-9]*],
>    SED=: aux_missing="$aux_missing sed")
> +AC_CHECK_PROG_VER(AWK, gawk, --version,
> +  [GNU Awk[^0-9]*\([0-9][0-9.]*\)],
> +  [[3-9].*], critic_missing="$critic_missing gawk")
>
>  AC_CHECK_TOOL(READELF, readelf, false)
>  AC_CHECK_TOOL(NM, nm, false)
> @@ -1043,7 +1046,6 @@ else
>  fi
>  AC_SUBST(libc_cv_have_ksh)
>
> -AC_PROG_AWK
>  AC_PATH_PROG(PERL, perl, no)
>  if test "$PERL" != no &&
>     (eval `$PERL -V:apiversion`; test `expr "$apiversion" \< 5` -ne 0); then
>

Yay!

It's one step forward for configure working properly :-)

This looks good to me. Please check this in.

Don't forget to update NEWS with the BZ#.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]