This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATH Optimized with SSE2 sinf and cof for x86_32
On Wed, 15 Aug 2012, Dmitrieva Liubov wrote:
> > This code is wrong. You cannot perform argument reduction for large
> > arguments by using a single, double, or even extended-precision
> > approximation for pi.
>
> Yes, that's wrong in x86_32 version and will be fixed but 64 bit
> version looks ok.
If that didn't get detected by the testsuite, I suppose we should add
0x1p+120 (or some such value that detects the problem) to the tests for
cos and sin in libm-test.inc. (The larest float value for cos in the
testsuite is 0x1p65; sin also tests 0x1.7f4134p+103.)
--
Joseph S. Myers
joseph@codesourcery.com