This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S/390: STT_GNU_IFUNC support
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Cc: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Date: Mon, 02 Jul 2012 15:20:30 +0200
- Subject: Re: [PATCH] S/390: STT_GNU_IFUNC support
- References: <20120702125139.GA6228@bart>
On Monday, July 02, 2012 14:51:39 Andreas Krebbel wrote:
> Hi,
>
> the attached patch adds support for STT_GNU_IFUNC symbols on S/390.
>
> The patch also adds optimized version for z10 and z196 of memcpy,
> memset, and memcmp. Starting with z10 these function are much faster
> when using the prefetch data instruction (pfd).
>
> With the patch glibc for S/390 needs the proper Binutils support to be
> in place as well:
>
> http://sourceware.org/ml/binutils/2012-07/msg00011.html
>
> All ifunc tests are clean on s390 and s390x.
So, do you want to add a configure test and only enable the IFUNC support
with new binutils? Or how do you want to handle the requirement?
Looking at your patch, we do not add the "Contributed by " anymore,
please remove lines like:
Contributed by Andreas Krebbel (krebbel@linux.vnet.ibm.com)
> [...]
> --- /dev/null
> +++ glibc/sysdeps/s390/s390-64/multiarch/ifunc-resolve.c
> @@ -0,0 +1,45 @@
> +#include <unistd.h>
This misses a copyright header (same for s390-32 version)
sysdeps/s390/s390-32/dl-machine.h misses an update of the copyright
header for the year 2012, please check all your changed files for that.
I think this deserves an entry to the NEWS file and suggets to add one.
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126